fix(MessageSearch): add threadId attribute for thread messages#15858
Merged
fix(MessageSearch): add threadId attribute for thread messages#15858
Conversation
Antreesy
added
3. to review
feature: api 🛠️
Contributor
Author
|
@miaulalala should we extend some existing integration tests? |
Contributor
not a bad idea. Want me to take a look? |
Contributor
Author
|
yesplease) feel free to push here |
miaulalala
force-pushed
the
fix/noid/search-provider-thread
branch
2 times, most recently
from
8ab5bc9 to
67d8ca6
Compare
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/noid/search-provider-thread
branch
from
cef3037 to
0d566d8
Compare
DorraJaouad
approved these changes
Sep 9, 2025
Contributor
Author
|
Thanks @miaulalala, that should work correctly with replies now. Cursor is 5-10 entries here, so should be fine with extra query for thread added |
Contributor
Author
|
/backport to stable32 |
| $messageStr, | ||
| $this->url->linkToRouteAbsolute('spreed.Page.showCall', ['token' => $room->getToken()]) . '#message_' . $comment->getId(), | ||
| $this->url->linkToRouteAbsolute('spreed.Page.showCall', ['token' => $room->getToken()]) | ||
| . ($thread !== null ? '?threadId=' . $thread->getId() : '') |
Member
There was a problem hiding this comment.
This is not how we build URLs in PHP, but I will fix it in #15880 where the same thing was introduced for a second place
|
|
||
| $threadId = (int)$comment->getTopmostParentId() ?: (int)$comment->getId(); | ||
| try { | ||
| $thread = $this->threadService->findByThreadId($room->getId(), $threadId); |
Member
There was a problem hiding this comment.
This does a query per search result.
Should be moved to a prepare step like we do in other places (same problem there is share loading)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🏁 Checklist
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required